This repository was archived by the owner on Aug 5, 2025. It is now read-only.
Separate path pings from normal pings #358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #355 but with an additional fix. Eagerly updating the URL bar doesn't work great in exercises like https://learn-svelte-dev-git-fork-tomoam-fix-348-svelte.vercel.app/tutorial/preload, because the browser doesn't update the URL bar until the navigation is committed. This means that the URL bar changes briefly, then reverts, then changes again once the navigation finishes.
(Technically it's incorrect to eagerly update the URL for a slow navigation, but that only affects a very small number of exercises — maybe just one — so I think it's worth it.)