This repository was archived by the owner on Aug 5, 2025. It is now read-only.
fix: improve styles inside the editor #366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tomoam is attempting to deploy a commit to the Svelte Team on Vercel. A member of the Team first needs to authorize it. |
tomoam
commented
Apr 14, 2023
Comment on lines
+22
to
+25
| .cm-editor .cm-activeLine { | ||
| background: var(--sk-back-translucent); | ||
| } | ||
|
|
There was a problem hiding this comment.
When dark mode in OS and light mode in learn.svelte.dev (and vice versa), the background of the active line looks like:
Adding the above code, it will only depend on the site's scheme, and will look like this:
tomoam
commented
Apr 14, 2023
| @@ -53,61 +53,82 @@ | |||
| } | |||
|
|
|||
| .cm-editor .cm-selectionMatch { | |||
| background: rgba(0,0,0,0.2); | |||
| background: var(--selection-color); | |||
There was a problem hiding this comment.
The similar applies here as well:
tomoam
commented
Apr 14, 2023
Comment on lines
+60
to
+66
| .cm-editor.cm-focused .cm-selectionBackground, | ||
| .cm-editor .cm-selectionBackground, | ||
| .cm-editor .cm-content ::selection { | ||
| background: var(--sk-theme-3); | ||
| opacity: .3; | ||
| } | ||
|
|
There was a problem hiding this comment.
The similar applies here as well:
tomoam
commented
Apr 14, 2023
Comment on lines
67
to
+80
| .cm-editor .cm-tooltip { | ||
| background: var(--sk-back-2); | ||
| color: var(--sk-text-1); | ||
| border: none; | ||
| border-radius: 2px; | ||
| overflow: hidden; | ||
| margin: 0.4rem 0; | ||
| filter: drop-shadow(1px 2px 5px rgba(0,0,0,0.1)); | ||
| } | ||
| .cm-editor .cm-tooltip-hover {} | ||
|
|
||
| .cm-editor .cm-tooltip-hover { | ||
| border: none; | ||
| } | ||
|
|
tomoam
commented
Apr 14, 2023
Comment on lines
+88
to
+93
|
|
||
| .cm-editor .cm-diagnostic-warning { | ||
| background: hsl(39, 100%, 70%); | ||
| background: var(--sk-theme-1-variant); | ||
| color: white; | ||
| } | ||
|
|
There was a problem hiding this comment.
The similar applies here as well:
tomoam
commented
Apr 14, 2023
Comment on lines
100
to
134
| .cm-editor .cm-panels { | ||
| background: var(--sk-back-4); | ||
| color: var(--sk-text-1); | ||
| } | ||
|
|
||
| @media (prefers-color-scheme: dark) { | ||
| .cm-editor .cm-activeLineGutter { | ||
| background-color: var(--sk-back-3); | ||
| } | ||
| .cm-editor .cm-panels.cm-panels-top, | ||
| .cm-editor .cm-panels.cm-panels-bottom { | ||
| border-top: 1px solid var(--sk-back-5); | ||
| border-bottom: 1px solid var(--sk-back-5); | ||
| } | ||
|
|
||
| .cm-editor .cm-activeLine { | ||
| background-color: hsl(0, 0%, 40%, 0.2); | ||
| } | ||
| .cm-editor .cm-button { | ||
| background: var(--sk-back-5); | ||
| border: 2px solid transparent; | ||
| } | ||
|
|
||
| .cm-editor .cm-diagnostic-warning { | ||
| background: hsl(39, 100%, 20%); | ||
| } | ||
| .cm-editor .cm-button:active { | ||
| background: var(--sk-theme-2-variant); | ||
| } | ||
|
|
||
| .cm-editor .cm-diagnostic-warning { | ||
| background: hsl(39, 100%, 10%); | ||
| } | ||
| .cm-editor .cm-textfield { | ||
| background: var(--sk-back-1); | ||
| color: var(--sk-text-1); | ||
| border: 2px solid transparent; | ||
| } | ||
|
|
||
| .cm-editor.cm-focused .cm-selectionBackground, | ||
| .cm-editor .cm-selectionBackground, | ||
| .cm-editor .cm-content ::selection { | ||
| background: var(--sk-theme-3); | ||
| opacity: .3; | ||
| } | ||
| .cm-editor .cm-search button:focus-visible, | ||
| .cm-editor .cm-search input:focus-visible { | ||
| border: 2px solid var(--flash); | ||
| } | ||
|
|
||
| .cm-editor .cm-selectionMatch { | ||
| background: rgba(255, 255, 255, 0.2); | ||
| } | ||
| } No newline at end of file | ||
| .cm-editor .cm-search input[type='checkbox']:focus-visible { | ||
| outline: 2px solid var(--flash); | ||
| } |
There was a problem hiding this comment.
Support dark mode for the search panel displayed by pressing Ctrl+F (Command+F on Mac).
dummdidumm
approved these changes
Apr 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #360
In addition to that, when set to dark-mode in OS and light-mode in learn.svelte.dev (and vice versa), I do not feel the css styles is good enough, so that fixes that as well.
I will add more details soon.I added it. please review.