Skip to content
This repository was archived by the owner on Aug 5, 2025. It is now read-only.

fix: env_file playwright tests failing due to animations #505

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

bamsargeant
Copy link
Contributor

Summary

Updated the env_file Playwright test to:

  • Correctly locate the header > button > h1 navigation dropdown menu
  • Update Playwright tests to use .getByRole() standards, as generic .locator() were clashing on multiple button elements
  • Disable animations to prevent expansion transitions from blocking clicks

Test Results

image

@vercel
Copy link

vercel bot commented Sep 18, 2023

@bamsargeant is attempting to deploy a commit to the Svelte Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Dec 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
learn-svelte-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 15, 2023 9:21pm

@Rich-Harris Rich-Harris merged commit 7eac90f into sveltejs:main Dec 15, 2023
@Rich-Harris
Copy link
Member

thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants