fix: check effect.pre in assign-in-effect #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems like the intention here was to check `$effect` _and_ `$effect.pre`, but the condition (`in_effect`) was filtering those out. The `is_rune` helper already does the same checks, so we can just remove the ones here and delegate to that.
🦋 Changeset detectedLatest commit: f3ee4ed The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@43081j is attempting to deploy a commit to the Svelte Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
paoloricciuti
previously approved these changes
Oct 4, 2025
|
@43081j can you fix the lint issues? |
|
ironically the error was that the changeset wasn't formatted 😅 should be fixed now |
Duh...I need to ignore changesets |
paoloricciuti
approved these changes
Oct 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like the intention here was to check
$effectand$effect.pre, but the condition (in_effect) was filtering those out.The
is_runehelper already does the same checks, so we can just removethe ones here and delegate to that.
If we don't want to report on
effect.pre, i can rework this to just remove the'$effect.pre'from the list of runes.