Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Sapper 0.15 compilation of routes w/ reserved name error #315

Closed
arxpoetica opened this issue Jul 24, 2018 · 2 comments · Fixed by #412
Closed

Sapper 0.15 compilation of routes w/ reserved name error #315

arxpoetica opened this issue Jul 24, 2018 · 2 comments · Fixed by #412

Comments

@arxpoetica
Copy link
Member

Compiling files like new.html or const.html chokes:

> const new = () =>
| 	import(/* webpackChunkName: "new" */ '../../routes/new.html');

@Conduitry thinks it's happening in create_manifests.ts, but:

I don't know whether the component name sanitization ought to be happening somewhere else

@Rich-Harris
Copy link
Member

we could just sanitize it here i think

name: get_slug(item.file),

i'm calling it a night, so, PRs welcome 😀

@Rich-Harris
Copy link
Member

Fixed in 0.19.2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants