Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Remove head hydration workaround #1067

Merged
merged 2 commits into from Aug 2, 2020
Merged

Remove head hydration workaround #1067

merged 2 commits into from Aug 2, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jan 23, 2020

Closes #1066

@benmccann
Copy link
Member

benmccann commented May 13, 2020

@johnmuhl should this also update the peerDependency in package.json to set svelte 3.17.3 as the minimum version required?

@antony antony added the breaking Breaking Changes label May 13, 2020
@antony antony added this to the 0.28 milestone Jul 30, 2020
@Conduitry
Copy link
Member

I'm taking a look at this again now that we're committed to the next release containing breaking changes - and I'm bothered that removing this isn't breaking any tests, even though we aren't updating any of the tests to include hydratable: true in the bundler's compiler config.

@benmccann
Copy link
Member

Every test already has hydratable: true in its rollup.config.js file, so I think that's to be expected

@Conduitry
Copy link
Member

The version of Svelte used in the tests in this branch is ancient though -

"version": "3.6.9",
- much older than the feature that this change relies on, which leads me to think this isn't being tested at all.

@benmccann
Copy link
Member

Yeah, there's just one test for hydration and it does't test the head element:

it('hydrates initial route', async () => {

Do we need to add a new test for it though? Svelte should have tests for head hydration and I'm not sure if we're doing anything special once the workaround is removed

@Conduitry
Copy link
Member

The pkg.peerDependencies should at least be updated to reflect the new requirement. This probably doesn't need to be called out in the migration section in the docs. I guess I'm okay without a test for this, since Svelte should be already testing it.

@benmccann
Copy link
Member

Ok, I just bumped the peerDependencies, so I'll go ahead and merge this one

@benmccann benmccann merged commit 95d93c7 into sveltejs:master Aug 2, 2020
habibrosyad pushed a commit to habibrosyad/sapper that referenced this pull request Aug 4, 2020
trmcnvn pushed a commit to metafy-gg/sapper that referenced this pull request Aug 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking Breaking Changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove head hydration workaround
3 participants