This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Allow usage of a valid Rollup config #1302
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmccann
force-pushed
the
valid-rollup-config
branch
from
807b6c2
to
ad394bc
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today it's not possible to use a valid Rollup configuration file with a Sapper project.
Forcing users to use an invalid config file doesn't have many benefits. It does have some drawbacks, however. E.g. it makes it harder to compare the output of Rollup's CLI implementation vs Sapper's Rollup CLI reimplementation. I've hit many issues here. Not being able to execute Rollup directly has caused a lot of difficulty in debugging and in requesting help from the Rollup team.
I implemented this looking at the name of the
input. Arguably we could instead add anidfield to look for though this would be a bit of a non-standard field. I filed a feature request to make it more standardized rollup/rollup#3687Eventually I'd like to consider moving the Sapper compiler to be a bundler plugin (#1346). This would be the first step of that. That would make it much easier to use other development systems like nollup, vite, or snowpack. Today there's no way to use an alternative bundler like nollup with Sapper because Sapper must have an implementation for every bundler. It'd be a small change to enable it (rixo@faca5e0) and @rixo already has a fork that does that, but I'm not sure it's the right separation of concerns that Sapper should have to know about every possible build system