This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Support preloading ES6 modules in exported pages #1539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, also added crossorigin=use-credentials
|
Why does the macOS-latest test fail? |
|
Probably just a flaky test - there are lots of timeouts on macOS tests. What are the package-lock.json updates in this PR? |
|
@Conduitry ouch that was a false commit. I've reverted it to the current master version and recommited. Still seems the last line |
|
Could be a new line at the end. GitHub won’t show me the diff on my phone, so I cannot check. |
|
Reverted the wrongly committed file to its master branch version. |
|
Thanks @benmccann ! |
benmccann
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…, also added crossorigin=use-credentials
Referencing #919