Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A way to delete saved REPLs #82

Closed
secretgspot opened this issue Aug 24, 2019 · 23 comments
Closed

A way to delete saved REPLs #82

secretgspot opened this issue Aug 24, 2019 · 23 comments
Labels

Comments

@secretgspot
Copy link

Is your feature request related to a problem? Please describe.
Yes, being a noob I forked same stuff over and over trying to figure out how it works and my saved list quickly grew to same stuff that is no longer needed.

Describe the solution you'd like
Would like a delete button on each saved REPL so it doesn't pollute your server and keeps my list clean and clear.

Describe alternatives you've considered
Abandoning ship, formatting computer and starting all over.

How important is this feature to you?
Very, since I use REPL feature a lot for practice and learning and would like to keep it in orderly fashion.

Additional context
n/a

@MarcRam
Copy link

MarcRam commented Aug 24, 2019

Being a noob myself, this are just my random thoughts and may not be accurate.

Have you considered that this requested feature would not be desirable in the context of a shared environment such as Svelte.dev where the examples on the REPL need to be accessible for others to view, and accidental erasure could lead to losing examples required for issue reports?

I don't yet know the structure of the REPL but, Would it be possible for you to simply delete the generated sub-directories on the command line to clean up on your forked version?

@secretgspot
Copy link
Author

I can share codepens and delete it at will, I can share jsfiddle and delete it at will. jsfiddle and codepen allow you to create anon repls which you can share and cannot be deleted.

@MarcRam
Copy link

MarcRam commented Aug 25, 2019

Very True, I suppose its just a matter of building the desired feature tied to a user ID and a no-delete flag.

What I should have said is that with limited development resources, I guess it will depend on how many people see your feature request as being valuable enough before it will get attention.

@pngwn
Copy link
Member

pngwn commented Aug 25, 2019

'Delete' could just remove them from your list but leave the repl untouched? Sounds like the problem is noise in your repl list rather than actually needing a repl deleted specifically.

@ghost
Copy link

ghost commented Oct 19, 2019

Another reason to be able to delete saved REPLs:

I don't know if it's a bug with the REPL, GitHub authentication, Firefox, or some combination of the three, but when I work on a single REPL, login, then save it a single time, I get the following in my saved apps list. Note: I named the app "Recursive" because I was testing out <svelte:self>, not because I expected this result. It is pretty ironic though...

image

@nickolasgregory
Copy link

Sorting alphabetically would be nice too.

@mattwolff
Copy link

mattwolff commented May 29, 2020

I agree, the option to delete (or at least remove them from my own list) would be fantastic. I've accidentally hit save on the Hello World REPL an embarrassing number of times...

That being said, maybe the Delete action should have some type of prompt in place: a kind of "ARE YOU SURE?" message to avoid accidental deletions as well.

@blazzjosh
Copy link

yep...we definitely need this feature....

Especially when we have duplicate Repls ...also named same ...🤷🏼‍♂️
Screen_Shot_2020-05-28_at_23 43 35

@opensas
Copy link

opensas commented Jun 5, 2020

I think that with a fine warning message (ARE YOU SURE?) would be enough. If the owner of the repl decide to break existing references that's fine, as long as he is not doing it by accident. Moreover, the owner can alway edit the repl and leave it empty, so it's the same.
Another nice thing would be to add an Archive option, to take it out of your list but leave it there for references.

@mlsks
Copy link

mlsks commented Jun 7, 2020

...Or when the App.svelte is left empty, it should be removed.

@markfirmware
Copy link

...Or when the App.svelte is left empty, it should be removed.

What I do is rename the title to empty.

@benwoodward
Copy link

If I have a repl with private data in it, I want to be able to remove it from your server. This should be reason enough to allow people to delete their repls. If I add data, I should be able to remove it.

@opensas
Copy link

opensas commented Dec 5, 2020 via email

@lukaszpolowczyk
Copy link
Contributor

If deleting a saved REPL is a problem, maybe the function... hide in the list https://svelte.dev/apps?

Because it's really about getting this list right.

It can work like this:

  • you click "hide" button
  • a saved REPL turns gray and moves to the bottom of the list - regardless of the date when the saved REPL was updated

The code is still there, the REPL link is still working, Google is still indexing it.

And that's all. Is this a good compromise?

@MinecraftPublisher
Copy link

Please svelte team, We need this! And the autosave, Why don't you make a better REPL interface?

@bluwy
Copy link
Member

bluwy commented Aug 9, 2021

I tried to tackle this a few weeks ago. It wasn't hard to support deleting repls from the database. The main issue was that there isn't a clear consensus how should we fix this.

From the discussion, we know that:

  1. Don't do deletes in the database, just hide it visually (comment)
  2. ??

Unresolved questions:

  1. How should we communicate that something will be hidden? confirm()? Custom UI?
  2. How do we let users unhide hidden repls? Do we need to?
  3. How to display hidden repls, in a custom section (needs design)? or just dim the repl?

Before one actually sends a PR for this, we need these questions resolved. Otherwise, we'll only get them answered when the PR is reviewed (and probably cause wasted work).

@opensas
Copy link

opensas commented Aug 9, 2021

Just to give my two cents to the discussion, and specially because I think svelte repl is an esential tool to showcase svelte, teach how it works, report issues, and brag about it with the rest of the frameworks:

  1. Don't do deletes in the databse, just hide it visually
    if it's not really a problem to have all those dead repl hanging around, I'm ok with that
  2. I guess the option two would be to just delete them, and leave everything as if it never existed

Unresolved questions:

Taking the first option, I would mark the "visually deleted" items as archived

  1. How to display hidden repls, in a custom section (needs design)? or just dim the repl?

After you log in and go to your saved apps you will only see the active repls (those which are not archived) and a link with the see archived repls next to Your apps title

Once you click see archived repls the link should turn into see active repls, and only the archived repls should be listed

Another option would be to make a show archived repls checkbox, initially unchecked, and only when you check it archived repls would appear right next to the rest of the repls.

  1. How do we let users unhide hidden repls? Do we need to?

When you are browsing active repls, an archive link should appear next to each repl, and when you are browsing archived links there should be an unarchive link next to each repl.

Optionally each repl could also have a delete link, that would effectively delete it, in case we want to have both options (logical and physical delete, to name it somehow)

  1. How should we communicate that something will be hidden?

Not sure about this one, I can imagine the following options

  1. do nothing, just make the repl disappear from the repl list, it will appear in the list of archived repls
  2. confirmation box Are you sure you want to archive this repl
  3. Floating undo repl archive link for a couple of seconds

I think the most comfortable one for the user would be the third option, although I guess it would be a bit harder to implement

@silverdr
Copy link

silverdr commented Dec 9, 2021

FWIW - my $0.02 would be: keep it really simple at least at first:

  • have a "Delete" button on the list
  • present a big warning upon clicking
  • done (including removing from DB)

At some point later we can think of more sophisticated stuff like archive/unarchive for example - if really needed.

@bluwy
Copy link
Member

bluwy commented Dec 9, 2021

Note: We're currently migrating the site to https://github.com/sveltejs/sites through #78, which will be using a new backend at https://github.com/sveltejs/api.svelte.dev. If anyone wants to tackle this, I'd hold off until the PR is merged.

@pngwn
Copy link
Member

pngwn commented Dec 15, 2021

FWIW - my $0.02 would be: keep it really simple at least at first:

  • have a "Delete" button on the list
  • present a big warning upon clicking
  • done (including removing from DB)

At some point later we can think of more sophisticated stuff like archive/unarchive for example - if really needed.

This is simple but destructive, there is no walking that option back. I'd opt for just hiding it for now.

To do this we need to store some hidden/ viewable metadata along with the gist.

@pngwn pngwn transferred this issue from sveltejs/svelte Dec 15, 2021
@rchrdnsh
Copy link

My main use case is that seeing all my old REPL's is a bunch of noise when I'm trying to find a specific one, so having the ability to hide/show them would be great, and maybe in the future being able to tag REPL's would be even better. And being able to create lists/groups/categories of REPL's would be even more better...er :-)

I wouldn't necessarily take completely deleting REPL's off the table, but make it tough to do so, which would require a explicit and extensive action by the author to delete the REPL.

@opensas
Copy link

opensas commented Dec 15, 2021

Yes, perhaps it's better to go directly for the tagging option and handle deleted ones with an archived tag.
The metadata to add could be a comma separated list of tags, and the ui could have an option to delete/undetele repls that would just add and remove the archived tag.

@benmccann benmccann added the REPL label Dec 15, 2021
@Rich-Harris
Copy link
Member

It's now possible to delete stuff via https://svelte.dev/apps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests