Add types for parser services

[marekdedic]

The parser services are currently typed as Record<string, any> - see

svelte-eslint-parser/src/parser/index.ts

Line 53 in d42120a

services?: Record<string, any>;

Would it be possible to add stricter types for them?

[ota-meshi]

Thank you for posting this issue.
Hmm. However we also use another parser within this parser.
We don't know what that parser provides through services. And export it as it is.

svelte-eslint-parser/src/parser/index.ts

Line 195 in 438be64

resultScript.services = Object.assign(resultScript.services || {}, {

So the current type is correct.
I think it might be nice if only the services that this parser explicitly provides can be correctly typed, and any otherwise.

[marekdedic]

Hmm, could we do something like services: typeof existingServices & {ourService: (string) => number}?

[baseballyama]

It’s difficult to apply appropriate types since we cannot predict what kind of parser a user will specify. For now, I will close this issue. Let’s reopen it when someone comes up with a good idea.

[marekdedic]

Hmm, thanks for the explanation. Maybe a dumb question, but wouldn't generics work here? Making

export interface ESLintExtendedProgram<T extends Record<string, any> = Record<string, any>> {
  services?: T;
}

Thanks!