Skip to content

Conversation

russelgal
Copy link
Contributor

No description provided.

@rixo
Copy link
Collaborator

rixo commented Jan 20, 2020

Thanks for your contribution.

999 seems pretty ad hoc to me though, it would fix only a subset of the problematic cases... Should we set it to the maximum allowed z-index of 2147483647 instead?

Also, what bundler are you using, Rollup or Webpack? The overlay code is duplicated in rollup-plugin-hot (not proud about that, didn't have time to sort it out yet)... You might want to change it there too?

@russelgal
Copy link
Contributor Author

999 seems pretty ad hoc to me though, it would fix only a subset of the problematic cases... Should we set it to the maximum allowed z-index of 2147483647 instead?

well, OK

Also, what bundler are you using, Rollup or Webpack? The overlay code is duplicated in rollup-plugin-hot (not proud about that, didn't have time to sort it out yet)... You might want to change it there too?

Webpack for now

@rixo rixo merged commit a90c9b5 into sveltejs:master Jan 26, 2020
@rixo
Copy link
Collaborator

rixo commented Jan 26, 2020

Published as svelte-loader-hot@0.1.2. Thanks for the other PR too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants