Skip to content

Disable package-lock.json #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

non25
Copy link
Contributor

@non25 non25 commented Jan 17, 2021

This ensures users will get up to date version of svelte-hmr without us
needing to republish svelte-loader with bumped version

This ensures users will get up to date version of svelte-hmr without us
needing to republish svelte-loader with bumped version
@non25
Copy link
Contributor Author

non25 commented Jan 17, 2021

It also fixes this https://github.com/rixo/svelte-hmr/pull/23 for Yarn 2 PnP.

@Conduitry
Copy link
Member

package-lock.json is not considered when someone is installing a library as a dependency. It's not even part of the published package. (https://unpkg.com/svelte-loader@2.13.6/package-lock.json) If package.json contains "svelte-hmr": "^0.12.2" then this will already resolve to 0.12.3 for new installations.

@non25
Copy link
Contributor Author

non25 commented Jan 17, 2021

Okay then. 😄

@non25 non25 closed this Jan 17, 2021
@non25 non25 deleted the package-lock branch January 17, 2021 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants