Skip to content

Conversation

dvrensk
Copy link
Contributor

@dvrensk dvrensk commented May 14, 2025

The button says "roll the dice" (plural) but the code only implements 1 singular die.

I understand the need of having issues and discussions, but I hope that fixing a label doesn't need that.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time.
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.

Copy link

vercel bot commented May 14, 2025

@dvrensk is attempting to deploy a commit to the Svelte Team on Vercel.

A member of the Team first needs to authorize it.

@dummdidumm
Copy link
Member

I didn't even know the singular of "dice" is "die" 😅 While more correct it seems it's more common to just say "dice" either way, which is why I lean towards keeping it as is. (context: not a native speaker)

@dvrensk
Copy link
Contributor Author

dvrensk commented May 15, 2025

I didn't even know the singular of "dice" is "die" 😅

Well, I didn't know that current usage is changing, so we've both learned something today 😆 . If I had known I wouldn't have created this PR in the first place. So close it or accept it, it's all the same to me.

@dummdidumm
Copy link
Member

Defering to some other native speakers for final verdict, cc @Rich-Harris / @Conduitry / @benmccann

@Rich-Harris
Copy link
Member

Yeah no-one says 'roll the die'. It's technically correct but it sounds very unidiomatic

@benmccann
Copy link
Member

The only proper solution is to add a second die, so that we can say dice and have it be correct 😄

@Conduitry
Copy link
Member

FWIW, I think I would say 'roll the die' if it were only one die being rolled.

@benmccann
Copy link
Member

FWIW, at the risk of complicating the matter, I probably would say "roll the die" for one as well

@dvrensk
Copy link
Contributor Author

dvrensk commented May 15, 2025

I'm almost sorry I started this discussion. I did originally consider submitting a PR to have it roll two dice instead. After all, it's more common in software that the label is right but the implementation is wrong.

I'd be happy to update this PR, or submit a new one. Or just drop it 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants