Migrate tutorial #145
Merged
Migrate tutorial #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
benmccann
reviewed
Sep 27, 2024
...ent/tutorial/01-svelte/02-reactivity/03-reactive-statements/+assets/app-b/src/lib/App.svelte
Outdated
Show resolved
Hide resolved
...v/content/tutorial/01-svelte/06-bindings/04-select-bindings/+assets/app-a/src/lib/App.svelte
Outdated
Show resolved
Hide resolved
...v/content/tutorial/01-svelte/06-bindings/04-select-bindings/+assets/app-b/src/lib/App.svelte
Outdated
Show resolved
Hide resolved
| @@ -1,11 +1,12 @@ | |||
| <script> | |||
| import { self } from 'svelte/legacy'; | |||
...t/tutorial/02-advanced-svelte/05-bindings/07-component-this/+assets/app-b/src/lib/App.svelte
Outdated
Show resolved
Hide resolved
...rial/02-advanced-svelte/09-special-elements/01-svelte-self/+assets/app-a/src/lib/File.svelte
Outdated
Show resolved
Hide resolved
| $effect(() => { | ||
| if ($navigating) { | ||
| start = Date.now(); |
There was a problem hiding this comment.
could some of these be set by a derived? or not possible since a store is being used?
There was a problem hiding this comment.
If we have $derived.by(prev => ...) then yes, but not like this (at least not in a straightforward way)
benmccann
reviewed
Sep 27, 2024
…m error/redirect)
dummdidumm
force-pushed
the
migrate-tutorial
branch
from
e1ee340 to
99cacda
Compare
|
Reverted the changes to Svelte for now, finished the changes for the SvelteKit tutorial (adjusted the MD files and also migrated towards SvelteKit 2.0, i.e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Took the migration script for a test drive, good results.
First commit is for SvelteKit tutorial, second for Svelte (we'll likely rewrite parts of it, but I thought it doesn't hurt in case we keep some parts like transitions which don't change).