Skip to content

Conversation

Rich-Harris
Copy link
Member

This attempts to fix #109, by making the sidebar scrollable, and #137 by positioning the sidebar relative to the left of the screen rather than the right.

@benmccann @dummdidumm can you try this out and see how it looks?

I don't think we can avoid having duplicate scroll bars on operating systems that still, in 2024, insist on rendering them for some reason. This PR tries to make it acceptable by shrinking the right sidebar such that a) they don't butt up against each other and b) it's very clear which sidebar relates to what content. But I have no way to judge how it looks.

Copy link

vercel bot commented Oct 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
omnisite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2024 9:11pm

@benmccann
Copy link
Member

This attempts to fix #109, by making the sidebar scrollable,

Definitely better than the status quo. The the double scroll bar in this PR doesn't look great though. I think if it were possible to hide the scrollbar, but still allow the section to be scrollable it might be preferable in this instance

and #137 by positioning the sidebar relative to the left of the screen rather than the right.

This one looks fixed. I see the scrollbar on the right of the screen still - not the left. But I no longer get the jumping effect

@Rich-Harris
Copy link
Member Author

Isn't hiding scrollbars on platforms where they'd normally render considered bad form? Most of the time it won't appear, since the list won't be tall enough

@Rich-Harris Rich-Harris mentioned this pull request Oct 3, 2024
@benmccann
Copy link
Member

Isn't hiding scrollbars on platforms where they'd normally render considered bad form?

Yeah, but so is having multiple scrollbars on a page. I wouldn't hide them as a matter of practice, but it might be the lesser of two evils in this case. I'd be curious for more opinions on it though

@dummdidumm
Copy link
Member

The double scrollbar looks awful, I'm with Ben here - better to hide it in this case. In fact it is already implemented this way on the current site (see https://svelte.dev/docs/accessibility-warnings for example), so I'm not 100% sure when this regressed on the omnisite.

@Rich-Harris
Copy link
Member Author

discovered scrollbar-width: none, which I think should do the trick. Fixed a few other lil glitches while I was at it. Will be optimistic and assume this is fixed

@Rich-Harris Rich-Harris merged commit 0a066e8 into main Oct 4, 2024
3 checks passed
@Rich-Harris Rich-Harris deleted the gh-109 branch October 4, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On This Page can overflow the screen
3 participants