Skip to content

Conversation

Rich-Harris
Copy link
Member

@Rich-Harris Rich-Harris commented Oct 5, 2024

Still needs some visual finessing but I think this is a better use of space than what we have now.

The post page needs some work — there's some funky stuff going on with some of these pages:

Copy link

vercel bot commented Oct 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
omnisite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 0:25am

@benmccann
Copy link
Member

Yeah, I like the two column approach

https://svelte-omnisite.vercel.app/blog/svelte-5-release-candidate

I don't know if it's just the connection I'm on, but the video embed doesn't work for me on this page. The youtube-nocookie site doesn't load

@dummdidumm
Copy link
Member

What browser are you using? This is likely due to the cross origin headers we're setting. I did set a attribute on the embeddings to make them work but it may only work on chromium based browsers. Wondering if we need full page navigations on some pages after all

@dummdidumm
Copy link
Member

Merged main into this branch, for Chrome it should display the iframe now. Doesn't work for other browsers though AFAIK. Maybe we need to mess around with full page navigations in some cases ...

As for the look:

I think this needs a bit more life, just too much text and nothing else. What if we render the OG card for the latest post?

The separation into one big and one small column, with the small listing out months makes it look like a "on this page" and I can skim through blog posts at that specific months. That was confusing to me.

@Rich-Harris
Copy link
Member Author

I added bylines (which spaces things out more nicely, and adds some colour and variety as well as showcasing the breadth of writers, at least from 2020 onwards) and turned the feed into a simple list which calms the page down a lot. I changed the title of the feed to 'monthly updates' which is hopefully clearer. Worst case scenario, someone has to learn what it is by clicking on it.

Rendering the OG card here would look very strange!

@Rich-Harris
Copy link
Member Author

gonna merge this so i can start creating issues for nits in the posts themselves

@Rich-Harris Rich-Harris merged commit 2ecb261 into main Oct 7, 2024
3 checks passed
@Rich-Harris Rich-Harris deleted the blog-index branch October 7, 2024 13:05
@Rich-Harris Rich-Harris mentioned this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants