Skip to content

fix: disable nav scroll while menu is open #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

cowboycodr
Copy link
Contributor

  • It's really useful if your PR references an issue where it is discussed ahead of time.
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.

Disables scrolling while the nav menu is open. Solves #515, where the bug is better described in-depth. Accomplished by setting the body's overflow style to 'hidden' when the menu is open.

image

Copy link

vercel bot commented Oct 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
learn-svelte-dev 🛑 Canceled (Inspect) Oct 23, 2024 3:37pm
omnisite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2024 3:37pm

@Rich-Harris Rich-Harris merged commit e1a1d16 into sveltejs:main Oct 23, 2024
7 checks passed
@Rich-Harris
Copy link
Member

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants