banner: Svelte Hack 2024

[PuruVJ]

Closes #617

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
kit-svelte-dev	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Oct 25, 2024 0:43am
learn-svelte-dev	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 25, 2024 0:43am
omnisite	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 25, 2024 0:43am
svelte-5-preview	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Oct 25, 2024 0:43am
svelte-dev	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Oct 25, 2024 0:43am

[bleucitron]

Is it possible to handle banners without endDate ? i'd like to add one on the french version to warn people the translation is WIP, but i need to specify and endDate to make it appear.

I can set some random date in the future of course, but this could be nice to have.

[bleucitron]

also, do banners need to always be links ?

(i can open an issue for these 2 points if you'd like)

[PuruVJ]

Is it possible to handle banners without endDate ? i'd like to add one on the french version to warn people the translation is WIP, but i need to specify and endDate to make it appear.

You could add a date for 100 years after now 😄. It can be added to the site, but I see Rich removed the defineBanner function, which couldve dealt with an infinite endDate, so IG endDate is now explicit.

also, do banners need to always be links ?

You could apply an action in your own repo to the Banner component. Allowing it to do more things could make the API very complicated for not much ROI