update hash on mouseleave and before reload #631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
will go ahead and merge because not having titles kept is annoying and this PR fixes it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the playground URL hash on
mouseleave, which means that if you move the mouse out of the editor to select the URL bar, the hash is updated before you select it which feels a bit nicer.It also uses the short-lived
sessionStoragetrick suggested in #507 (comment) to save stuff immediately before a reload. (I also tried intercepting the keypresses that would lead to a reload and preventing the default, but a) it felt a bit naughty and b) it wouldn't work on mobile.)