Skip to content

Conversation

Rich-Harris
Copy link
Member

@dummdidumm how's this?

Copy link

vercel bot commented Oct 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
svelte-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2024 1:46am

@dummdidumm
Copy link
Member

yeah much better - should be done for the sans-serif font as-well.

@Rich-Harris
Copy link
Member Author

Why? The reason to change the size of Georgia is that it has fatter glyphs than EB Garamond. If we change the size of the sans font on low res screens it'll just mess up the ratio of body copy font size to everything else.

Unless you're saying we should change the sans font size across the board? That seemed to be an unpopular opinion before

@dummdidumm
Copy link
Member

dummdidumm commented Oct 28, 2024

This is how much I get to see on the old site, which was pleasant to read size-wise
image

This is how much I get to see on the new site currently (using sans-serif, with serif it's the same)
image

It's just way too big (screens taken from 27 inch monitor at fullscreen)

@dummdidumm
Copy link
Member

Reducing line-height would also help, line-height: 1.5 is good

@Rich-Harris
Copy link
Member Author

Oh, interesting — didn't realise that we had 1.7 for low resolution screens — I assume the intent was to have 1.7 for Georgia and everything else, but you were seeing 1.7 on low res screens in sans mode.

Changed it to be 1.5 across the board, I think it looks fine. I nudged the sans font size down as well

@dummdidumm dummdidumm merged commit 082ad3c into main Oct 29, 2024
5 checks passed
@dummdidumm dummdidumm deleted the shrink-georgia branch October 29, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants