Skip to content

Change Search Box escape key from e.code to e.key #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2024
Merged

Change Search Box escape key from e.code to e.key #741

merged 1 commit into from
Oct 31, 2024

Conversation

uglyreptile
Copy link
Contributor

Closes #740

@vercel Vercel
Copy link

vercel bot commented Oct 31, 2024

@uglyreptile is attempting to deploy a commit to the Svelte Team on Vercel.

A member of the Team first needs to authorize it.

@Rich-Harris Rich-Harris merged commit e78cb03 into sveltejs:main Oct 31, 2024
2 of 3 checks passed
@Rich-Harris
Copy link
Member

thanks! was unaware of this distinction

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rich-Harris Rich-Harris Rich-Harris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change escape key Search Box behavior
2 participants
@uglyreptile @Rich-Harris