Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add vim mode via query param #813

Merged
merged 1 commit into from
Nov 25, 2024
Merged

add vim mode via query param #813

merged 1 commit into from
Nov 25, 2024

Conversation

Rich-Harris
Copy link
Member

@Rich-Harris Rich-Harris commented Nov 6, 2024

Adding ?vim=true will enable Vim mode in the playground and tutorial. Ultimately it might be nice to have some UI around this, but I'm not sure what that looks like given it needs to work for both places.

In an ideal world we wouldn't need to mess around with compartments, we would just add the vim plugin to default_extensions directly. Unfortunately await import(...) at the top level doesn't work in Safari, because Safari is a bad piece of software, so we have to do this dance instead.

closes #570

@dummdidumm dummdidumm merged commit a9367a4 into main Nov 25, 2024
5 checks passed
@dummdidumm dummdidumm deleted the vim-mode branch November 25, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vim mode
2 participants