Skip to content

Conversation

Vardhaman619
Copy link
Contributor

In documentation "On this page" section :

  1. The first section link was not re-activating when scrolling back to the top after navigating down the page.
  2. The last section link was not activating when scroll to bottom.

Before:
before video

before.webm

After:
after-(first-and-last-link-working)-video

after-.first-and-last-links-working.webm

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time.
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.

Copy link

vercel bot commented Nov 16, 2024

@Vardhaman619 is attempting to deploy a commit to the Svelte Team on Vercel.

A member of the Team first needs to authorize it.

@Vardhaman619
Copy link
Contributor Author

@dummdidumm Could you please take a look at this pull request when you have a chance?

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@dummdidumm dummdidumm merged commit 2efd674 into sveltejs:main Dec 2, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants