fix: resolve module
and browser
conditions for fetched packages in REPL
#872
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe both of those should be added here:
module
is meant to help avoid dual package hazards because it allows bothrequire
andimport
to resolve to it and instantiate only a single instance of the package. Even though REPL is not a bundler, I don't see why this would not be something that you'd like to support here. It's legit forimport
to point to an.mjs
wrapper for the CJS content and this field can be used to point resolvers directly to ESM bundlesbrowser
- you already configurebrowser: true
but, according to the docs, that just enables support for the browser field (package.json#browser
). The proposed change should also add it to supportedexports
conditionsI verified manually that it fixes this REPL code: