docs: update sample code to replace deprecated <svelte:component> #919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nanggo is attempting to deploy a commit to the Svelte Team on Vercel. A member of the Team first needs to authorize it. |
dummdidumm
reviewed
Dec 3, 2024
There was a problem hiding this comment.
these changes seem unrelated, could you revert them? (if those changes should be made, they need to happen in the Svelte repo)
There was a problem hiding this comment.
I'm sorry about that. Should I just revert or need to force push at my fork repository?
I think something wrong because 06e0046 commits in.
This reverts commit 06e0046.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR updates the sample code in the SvelteKit tutorial for universal load functions. Specifically, the
<svelte:component>tag, which is deprecated inrunesmode, is replaced with a recommended alternative.Why
Using
<svelte:component>in the tutorial causes the following warning:The editor's solution already uses the updated code, but the sample code in the tutorial did not reflect this change.