Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only detach nodes if necessary #26

Closed
Rich-Harris opened this issue Nov 25, 2016 · 4 comments
Closed

Only detach nodes if necessary #26

Rich-Harris opened this issue Nov 25, 2016 · 4 comments

Comments

@Rich-Harris
Copy link
Member

@Rich-Harris Rich-Harris commented Nov 25, 2016

Right now, Svelte detaches every child of every node during teardown. It only needs to detach the top-level ones.

@pillaiindu
Copy link

@pillaiindu pillaiindu commented Jan 19, 2018

Is it fixed now?

@Rich-Harris
Copy link
Member Author

@Rich-Harris Rich-Harris commented Jan 19, 2018

yes! It's been fixed for over a year

@pillaiindu
Copy link

@pillaiindu pillaiindu commented Jan 20, 2018

The performance of Svelte for swapping rows in this benchmark was very slow. How would it behave now?

@Rich-Harris
Copy link
Member Author

@Rich-Harris Rich-Harris commented Jan 20, 2018

The same. There's an issue for it: #588. It hasn't been a big priority because it's a fairly contrived example you don't often encounter in the wild

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants