Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make @types/estree a dependency (v5) #10150

Merged
merged 1 commit into from
Jan 11, 2024
Merged

fix: make @types/estree a dependency (v5) #10150

merged 1 commit into from
Jan 11, 2024

Conversation

dummdidumm
Copy link
Member

types are exposed through our types, so we need to add it as a dependency fixes #10010

v5 version of #10149

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

types are exposed through our types, so we need to add it as a dependency
fixes #10010
Copy link

changeset-bot bot commented Jan 10, 2024

🦋 Changeset detected

Latest commit: 57c315f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
svelte-5-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2024 4:23pm

@dummdidumm dummdidumm merged commit da9a5bf into main Jan 11, 2024
9 checks passed
@dummdidumm dummdidumm deleted the estree-types-v5 branch January 11, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Estree types missing
2 participants