Skip to content

fix(repl): update broken embed repl to work like regular one #10180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

zusorio
Copy link

@zusorio zusorio commented Jan 13, 2024

I noticed that the /repl/embed route on svelte.dev is currently broken.
This PR fixes it and also moves it to be more in line with how the normal REPL works.
I've moved the route from /repl/embed?gist={id} to /repl/[id]/embed and set up a redirect.

Because of this, ReplWidget was only being used for the examples on the landing page, so I replaced it and removed ReplWidget.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Jan 13, 2024

⚠️ No Changeset found

Latest commit: c41fff0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@benmccann benmccann requested a review from PuruVJ January 14, 2024 03:44
@PuruVJ
Copy link
Collaborator

PuruVJ commented Jan 15, 2024

This looks amazing, thanks a lot!! Im travelling atm, so will test it out tomorrow and merge

@zusorio
Copy link
Author

zusorio commented Jan 18, 2024

Hey, I just wanted to ask if this PR will get merged before next Tuesday? I'm planning on using the embedded REPL in a presentation and wanted to know if I should set up my own deployment of the svelte REPL or if it'll be ready by then. If not that's totally fine, I'd just like to know so I can plan.

@PuruVJ
Copy link
Collaborator

PuruVJ commented Jan 18, 2024

Sure, will merge by sunday latest!

@PuruVJ PuruVJ merged commit 9d0f7d7 into sveltejs:svelte-4 Jan 22, 2024
@zusorio zusorio deleted the repl-embed-fix branch January 22, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants