Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure derived signals properly capture consumers #10213

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Jan 17, 2024

This is a follow up to #10209. Essentially there were a few bugs that came into play with unowned signals that made this a bit more complex to resolve.

  • When dealing with unowned signals (they were created without an owner effect), we were skipping consumers incorrectly. We should always add consumers when we're part of effect flushing, so now we use a dedicated flag is_flushing_effect.
  • The removal of consumers was broken and we were traversing through the current dependencies rather than the actual dependencies. Cleaned up the code to make it far clearer what is what.
  • When removing consumers we had a flag that was completely redundant - remove_unowned. We should always be removing unowned now that we have fix old issues around incorrectly removing consumers that didn't need to be removed.
  • We should only be marking effect signals inert, not derived signals.

Copy link

changeset-bot bot commented Jan 17, 2024

🦋 Changeset detected

Latest commit: ea63691

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
svelte-5-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2024 9:12pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant