Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disallow TODO errors #10326

Merged
merged 3 commits into from
Jan 29, 2024
Merged

fix: disallow TODO errors #10326

merged 3 commits into from
Jan 29, 2024

Conversation

Rich-Harris
Copy link
Member

@Rich-Harris Rich-Harris commented Jan 29, 2024

'TODO' is a placeholder error code — we shouldn't actually be shipping these. This PR makes it a type error so that we catch them early

Svelte 5 rewrite

Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (main).

If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is svelte-4 and not main.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Jan 29, 2024

🦋 Changeset detected

Latest commit: eb0085a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris Rich-Harris marked this pull request as ready for review January 29, 2024 19:32
@Rich-Harris Rich-Harris changed the title chore: disallow TODO errors fix: disallow TODO errors Jan 29, 2024
@Rich-Harris Rich-Harris merged commit 5ebd9e0 into main Jan 29, 2024
7 of 8 checks passed
@Rich-Harris Rich-Harris deleted the remove-todo-errors branch January 29, 2024 19:37
trueadm pushed a commit that referenced this pull request Jan 31, 2024
* disallow TODO errors

* replace TODO errors

* changeset

---------

Co-authored-by: Rich Harris <rich.harris@vercel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant