Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement :global {...} CSS blocks #11276

Merged
merged 4 commits into from
Apr 22, 2024
Merged

feat: implement :global {...} CSS blocks #11276

merged 4 commits into from
Apr 22, 2024

Conversation

Rich-Harris
Copy link
Member

closes #10815.

This makes it possible to define global (or child global) styles in a block. Instead of this...

<div class="post">
  {@html post.content}
</div>

<style>
  .post :global(p) {...}
  .post :global(ul) {...}
  .post :global(li) {...}
  .post :global(code) {...}
</style>

...you can now write this:

<div class="post">
  {@html post.content}
</div>

<style>
  .post :global {
    p {...}
    ul {...}
    li {...}
    code {...}
  }
</style>

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Apr 21, 2024

🦋 Changeset detected

Latest commit: 7598ce7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Conduitry
Copy link
Member

I'm guessing this does not provide a replacement for the other way - :global(.foo) .bar - and that we'll be keeping the :global() syntax around for the foreseeable future to support that case?

@Rich-Harris
Copy link
Member Author

Yeah, it'd be confusing/ambiguous if :global {...} did double-duty, so we'll need both

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte 5: add :global {...} nested selectors
2 participants