Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow for non optional chain call expression in render #11578

Merged

Conversation

paoloricciuti
Copy link
Member

Svelte 5 rewrite

The issue is not open yet but was highlighted on discord : i just removed the optional check, tests and runtime seems to work fine but i would love a bit of insight from @dummdidumm about why he included that check in #10656

Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (main).

If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is svelte-4 and not main.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented May 13, 2024

🦋 Changeset detected

Latest commit: 3d96ba5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea honestly, change looks good

@dummdidumm dummdidumm merged commit 81517a5 into sveltejs:main May 13, 2024
6 of 8 checks passed
@mimbrown
Copy link
Contributor

So this will allow a.b() but not a.b.c(), which feels a little arbitrary. From what I can tell they were trying not to allow any chained syntax other than a single nullish call a?.(), but it mistakenly also allowed a?.b?.() (but not a?.b()). I don't know that this truly fixes the issue.

@mimbrown
Copy link
Contributor

Ah never mind, I misread the AST.

@paoloricciuti
Copy link
Member Author

So this will allow a.b() but not a.b.c(), which feels a little arbitrary. From what I can tell they were trying not to allow any chained syntax other than a single nullish call a?.(), but it mistakenly also allowed a?.b?.() (but not a?.b()). I don't know that this truly fixes the issue.

As Simon pointed out in the original pr the AST is a little weird but basically it will always be a CallExpression or a ChainedExpression with a CallExpression. Basically

a.b.c();

will be a a.b ChainedExpression with a c() CallExpression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants