Skip to content

fix: ensure dynamic call expressions correctly generate output #14345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2024
Merged

fix: ensure dynamic call expressions correctly generate output #14345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/moody-bears-change.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

fix: ensure dynamic call expressions correctly generate output
2 changes: 2 additions & 0 deletions packages/svelte/src/compiler/phases/2-analyze/visitors/CallExpression.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import { get_rune } from '../../scope.js';
import * as e from '../../../errors.js';
import { get_parent, unwrap_optional } from '../../../utils/ast.js';
import { is_pure, is_safe_identifier } from './shared/utils.js';
import { mark_subtree_dynamic } from './shared/fragment.js';

/**
* @param {CallExpression} node
Expand Down Expand Up @@ -179,6 +180,7 @@ export function CallExpression(node, context) {
context.state.expression.has_call = true;
context.state.expression.has_state = true;
context.state.expression.can_inline = false;
mark_subtree_dynamic(context.path);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good, just for the sake of it, can we check wherever else we set can_inline to false to see if the subtree is actually marked dynamic?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added it to other places but didn't notice any differences. Which was odd, but this whole inline/dynamic system feels a bit wonky tbh.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah i think we need to restructure this a bit to keep a single source of truth (but i think it will be difficult)

}
}
}
5 changes: 5 additions & 0 deletions packages/svelte/tests/runtime-legacy/samples/inline-expressions-subtree/_config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
import { test } from '../../test';

export default test({
html: '<span class="red">A</span>\n<div><span class="red">B</span></div>'
});
4 changes: 4 additions & 0 deletions packages/svelte/tests/runtime-legacy/samples/inline-expressions-subtree/main.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
<span class={(() => 'red')()}>A</span>
<div>
<span class={(() => 'red')()}>B</span>
</div>
Loading