chore: replace queue_idle_task with queue_micro_task #16844
Merged
+3
−33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use
queue_idle_task
in exactly one place — removing defaults from inputs. To my mind it really doesn't warrant this special treatment — you have to have hundreds of<input>
elements with a server-renderedvalue
orchecked
attribute before it takes more than a single millisecond to remove all those attributes, at least on this four year old machine, and if they don't have avalue
attribute then you're actually making things worse withrequestIdleCallback
.Just feels like a bad use of our complexity budget.
I think we can actually go further in simplifying this — like, what if we didn't bother removing these attributes at all until the form in question gets reset? — but for now I'm focused on just removing
queue_idle_task
to unblock further simplifications as to how we schedule things.