Skip to content

reactivity: run $effect immediately after async derived resolves (non-suspend path)(#16497) #16884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −0
Open

reactivity: run $effect immediately after async derived resolves (non-suspend path)(#16497) #16884

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/svelte/src/internal/client/reactivity/deriveds.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,13 @@ export function async_derived(fn, location) {
if (should_suspend) {
boundary.update_pending_count(-1);
if (!pending) batch.decrement();
} else {
// Ensure effects depending on this async derived run promptly when we didn't suspend
// and there is no pending boundary — commit queued work immediately.
if (!pending) {
batch.flush();
batch.deactivate();
}
}

unset_context();
Expand Down
Loading