Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly escape sharedPath in generated import statements #229

Merged
merged 1 commit into from
Jan 3, 2017
Merged

Properly escape sharedPath in generated import statements #229

merged 1 commit into from
Jan 3, 2017

Conversation

Conduitry
Copy link
Member

If the sharedPath contains any special characters, the generated import statement is not correctly escaping them. This PR fixes that.

As an added bonus, unit tests pass on Windows again. Previously, the unit tests which used shared were generating

import { things } from 'C:\some\path\svelte\shared.js'

which is the same as 'C:somepathsvelteshared.js', which reify rightfully balked at.

@delbeke
Copy link

delbeke commented Dec 28, 2016

+1

1 similar comment
@barak007
Copy link

+1

@Rich-Harris Rich-Harris merged commit 5737c60 into sveltejs:master Jan 3, 2017
@Rich-Harris
Copy link
Member

thank you!

@Conduitry Conduitry deleted the escape-shared-path branch January 3, 2017 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants