New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for #2655 - adding introstart...outroend events to in-out transition #2912

Merged

Rich-Harris merged 1 commit into sveltejs:master from yazonnile:master

Jun 2, 2019

yazonnile commented May 30, 2019

If your pull request implements a new feature, please raise an issue to discuss it before sending code. In many cases features are absent for a reason.

Its not a new feature. Its a missed functionality, I guess.

This message body should clearly illustrate what problems it solves. If there are related issues, remember to reference them.

Specific transition events (introstart, introend, outrostart, outroend) work just with using transition directive, but not in the case of in:fade or out:fade ( Transitions events not working for in and out #2655 )

Ideally, include a test that fails without this PR but passes with it. PRs will only be merged once they pass CI. (Remember to npm run lint!)

Test added


          Fix for #2655 - adding introstart...outroend events to in-out transition

2785fa6

Rich-Harris merged commit eb4e5e0 into sveltejs:master

Member

Rich-Harris commented Jun 2, 2019

excellent, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment