Skip to content

Conversation

Jongkeun
Copy link
Contributor

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR relates to an outstanding issue, so please reference it in your PR, or create an explanatory one for discussion. In many cases features are absent for a reason.
  • This message body should clearly illustrate what problems it solves. If there are related issues, remember to reference them.
  • Ideally, include a test that fails without this PR but passes with it. PRs will only be merged once they pass CI. (Remember to npm run lint!)

Tests

  • Run the tests tests with npm test or yarn test)

fixed #4594

When I saved some files, it was changed automatically due to vscode setting.
vscode default setting value of typescript.format.insertSpaceAfterFunctionKeywordForAnonymousFunctions is true
And I use this setting value all of my workspaces.

But it seems like svelte project is using false.
I want to try to join this project, but I couldn't change default settings for only this project.
Because my other projects are using true.
So I set some setting values and don't want to commit, because other people don't need this value.

I thought I would commit my .vscode/settings.json, but you might not want it.
So I commit only .gitignore 😃

@Jongkeun
Copy link
Contributor Author

It was passed at my pc.
Should I something to do?😅

@Conduitry
Copy link
Member

This makes sense. I also have a project-local .vscode/settings.json that overrides a couple of things, and I added it to .git/info/exclude, but having it in the shared .gitignore is probably more user friendly.

@Conduitry Conduitry merged commit aa3dcc0 into sveltejs:master Mar 24, 2020
sthagen added a commit to sthagen/sveltejs-svelte that referenced this pull request Apr 1, 2020
taylorzane pushed a commit to taylorzane/svelte that referenced this pull request Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vscode workspace setting value
2 participants