-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix perserveComments on ssr (#4730) #4736
Conversation
First of all thanks for making a PR for my issue 🙂
I needed to patch this behavior in #4737 anyway, see my solution. |
😀 i had something similar but after discovering the existing test I removed it. |
Please don't close this one, my other PR is just for whitespace! 🙂 |
ah of course.. 🤦 |
hmm.. i see @Rich-Harris didn't follow up on his promise over there: #3539 (comment) |
oh this is still open 🙃 is it still relevant? I can try to solve the conflict |
d78b936
to
c09bc95
Compare
no worries, i've rebased and fixed the conflicts |
Fixes #4730
Should I create a test in
server-side-rendering/samples
or the existing one injs/samples/ssr-preserve-comments
is enough?Adding the test in server-side-rendering will require an extra config flag to not use
assert.htmlEqual
on that specific test, as it removes comments.