More forgiving SvelteComponentDev typings #5937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `$$events_def` and `$$slot_def` so that users can do
```
let el: SvelteComponent;
<SomeComponent bind:this={el} />
```
Without type errors.
Without this change, TS complains that `$$events_def` and `$$slot_def` is missing from `SvelteComponentDev` and therefore cannot be assigned to it.
|
Included in 3.32.1, thanks! |
hontas
added a commit
to hontas/svelte
that referenced
this pull request
Feb 11, 2021
* 'master' of https://github.com/sveltejs/svelte: (129 commits) -> v3.32.3 fix remove of lone :host selectors (sveltejs#5984) -> v3.32.2 update changelog fix extra invalidation with component prop binding to object property (sveltejs#5890) update css-tree@^1.1.2 (sveltejs#5958) fix :host and :global css scoping (sveltejs#5957) Tutorial : a better explanation of component events (sveltejs#4639) "What's new in Svelte" February newsletter (sveltejs#5925) Change color on 404 page (sveltejs#5932) -> v3.32.1 warn module variables are nonreactive and make them truly nonreactive (sveltejs#5847) update changelog fix: "foreign" namespace elements should still allow binding 'this' (sveltejs#5942) inline `prop_values` in `init` helper (sveltejs#5909) update changelog don't create class update functions when dependencies aren't reactive (sveltejs#5926) fix extraneous store subscription in SSR (sveltejs#5929) make `SvelteComponentDev` typings more forgiving (sveltejs#5937) make animation/transition params optional (sveltejs#5936) ...
This was referenced Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
$$events_defand$$slot_defso that TS users can doWithout type errors.
Without this change, TS complains that
$$events_defand$$slot_defis missing fromSvelteComponentDevand therefore cannot be assigned to it.Before submitting the PR, please make sure you do the following
Tests
npm testand lint the project withnpm run lint