Skip to content

chore: upgrade aria-query and axobject-query #8724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 14, 2023
Merged

chore: upgrade aria-query and axobject-query #8724

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2ebbdc0
chore: upgrade aria-query and axobject-query
benmccann Jun 13, 2023
d767a1d
remove util hacks
benmccann Jun 13, 2023
8af032c
update test fixtures
gtm-nayan Jun 13, 2023
e5b4922
merge
benmccann Jun 14, 2023
9ef970d
add link to TODOs
benmccann Jun 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions packages/svelte/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,8 @@
"@ampproject/remapping": "^2.2.1",
"@jridgewell/sourcemap-codec": "^1.4.15",
"acorn": "^8.8.2",
"aria-query": "^5.1.3",
"axobject-query": "^3.1.1",
"aria-query": "^5.2.1",
"axobject-query": "^3.2.1",
"code-red": "^1.0.0",
"css-tree": "^2.3.1",
"estree-walker": "^3.0.3",
Expand All @@ -118,7 +118,6 @@
"@rollup/plugin-commonjs": "^24.1.0",
"@rollup/plugin-json": "^6.0.0",
"@rollup/plugin-node-resolve": "^15.0.2",
"@rollup/plugin-replace": "^5.0.2",
"@sveltejs/eslint-config": "^6.0.4",
"@types/aria-query": "^5.0.1",
"@types/estree": "^1.0.1",
Expand All @@ -133,7 +132,6 @@
"source-map": "^0.7.4",
"tiny-glob": "^0.2.9",
"typescript": "^5.0.4",
"util": "^0.12.5",
"vitest": "^0.31.1"
}
}
12 changes: 0 additions & 12 deletions packages/svelte/rollup.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import fs from 'node:fs';
import { createRequire } from 'node:module';
import replace from '@rollup/plugin-replace';
import resolve from '@rollup/plugin-node-resolve';
import commonjs from '@rollup/plugin-commonjs';
import json from '@rollup/plugin-json';
Expand All @@ -25,19 +24,8 @@ export default [
{
input: 'src/compiler/index.js',
plugins: [
replace({
preventAssignment: true,
values: {
'process.env.NODE_DEBUG': false // appears inside the util package
}
}),
{
resolveId(id) {
// util is a built-in module in Node.js, but we want a self-contained compiler bundle
// that also works in the browser, so we load its polyfill instead
if (id === 'util') {
return require.resolve('./node_modules/util'); // just 'utils' would resolve this to the built-in module
}
// Must import from the `css-tree` browser bundled distribution due to `createRequire` usage if importing from css-tree directly
if (id === 'css-tree') {
return require.resolve('./node_modules/css-tree/dist/csstree.esm.js');
Expand Down
2 changes: 1 addition & 1 deletion ...te/test/validator/samples/a11y-no-interactive-element-to-noninteractive-role/input.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,6 @@
<menuitem role="listitem" />
<option class="foo" role="listitem" />
<select class="foo" role="listitem" />
<summary role="listitem" />
<summary role="listitem" /> // TODO: https://github.com/sveltejs/svelte/issues/8728
<textarea class="foo" role="listitem" />
<tr role="listitem" />
12 changes: 0 additions & 12 deletions ...e/test/validator/samples/a11y-no-interactive-element-to-noninteractive-role/warnings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -671,18 +671,6 @@
"line": 145
}
},
{
"code": "a11y-no-interactive-element-to-noninteractive-role",
"end": {
"column": 27,
"line": 146
},
"message": "A11y: <summary> cannot have role 'listitem'",
"start": {
"column": 0,
"line": 146
}
},
{
"code": "a11y-no-interactive-element-to-noninteractive-role",
"end": {
Expand Down
6 changes: 3 additions & 3 deletions ...te/test/validator/samples/a11y-no-noninteractive-element-to-interactive-role/input.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<article role="button" />
<aside role="checkbox" aria-checked={false} />
<blockquote role="columnheader" />
<body role="combobox" aria-controls={[]} aria-expanded />
<body role="combobox" aria-controls={[]} aria-expanded /> // TODO: https://github.com/sveltejs/svelte/issues/8728
<br role="grid" />
<caption role="gridcell" />
<dd role="link" />
Expand All @@ -18,7 +18,7 @@
<figure role="option" aria-selected />
<footer role="radio" aria-checked />
<form role="radiogroup" />
<frame role="row" />
<frame role="row" /> // TODO: https://github.com/sveltejs/svelte/issues/8728
<h1 role="rowheader">Button</h1>
<h2 role="scrollbar" aria-controls={[]} aria-valuenow={0} >Button</h2>
<h3 role="searchbox">Button</h3>
Expand Down Expand Up @@ -46,7 +46,7 @@
<section role="radio" aria-label="radio" aria-checked />
<table role="menu" />
<tbody role="searchbox" />
<td role="button" />
<td role="button" /> // TODO: https://github.com/sveltejs/svelte/issues/8728
<tfoot role="listbox" />
<thead role="slider" aria-valuenow={0} />
<time role="doc-backlink" />
Expand Down
36 changes: 0 additions & 36 deletions ...e/test/validator/samples/a11y-no-noninteractive-element-to-interactive-role/warnings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,18 +35,6 @@
"line": 4
}
},
{
"code": "a11y-no-noninteractive-element-to-interactive-role",
"end": {
"column": 57,
"line": 5
},
"message": "A11y: Non-interactive element <body> cannot have interactive role 'combobox'",
"start": {
"column": 0,
"line": 5
}
},
{
"code": "a11y-no-noninteractive-element-to-interactive-role",
"end": {
Expand Down Expand Up @@ -203,18 +191,6 @@
"line": 20
}
},
{
"code": "a11y-no-noninteractive-element-to-interactive-role",
"end": {
"column": 20,
"line": 21
},
"message": "A11y: Non-interactive element <frame> cannot have interactive role 'row'",
"start": {
"column": 0,
"line": 21
}
},
{
"code": "a11y-no-noninteractive-element-to-interactive-role",
"end": {
Expand Down Expand Up @@ -563,18 +539,6 @@
"line": 48
}
},
{
"code": "a11y-no-noninteractive-element-to-interactive-role",
"end": {
"column": 20,
"line": 49
},
"message": "A11y: Non-interactive element <td> cannot have interactive role 'button'",
"start": {
"column": 0,
"line": 49
}
},
{
"code": "a11y-no-noninteractive-element-to-interactive-role",
"end": {
Expand Down
Loading