docs: fix attribute example in basic markup #8813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ugh, I think Prettier did this and turned everything it can into shorthands. I wonder how many others there are. |
gtm-nayan
approved these changes
Jun 23, 2023
5 tasks
Epenance
commented
Jun 23, 2023
| <button disabled={disabled}>...</button> | ||
| --> |
There was a problem hiding this comment.
This seems to be wrong, I'll create a PR to fix this.
Epenance
commented
Jun 23, 2023
| <input bind:value /> | ||
| <!-- equivalent to | ||
| <input bind:value={value} /> |
There was a problem hiding this comment.
Same here, or are you doing this to ensure Prettier doesnt pick it up?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current documentation has an example saying "These are equivalent" but shows the same line of code twice.
I made a small change to actually show the two lines I believe are ment to be there.