Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle dynamic selects with falsy select values #9471

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Conversation

dummdidumm
Copy link
Member

when options are added later, we need to ensure the select value still stays in sync
fixes #9412

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

when options are added later, we need to ensure the select value still stays in sync
fixes #9412
Copy link

changeset-bot bot commented Nov 15, 2023

🦋 Changeset detected

Latest commit: 8d84647

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
svelte-5-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2023 4:45pm

@trueadm trueadm merged commit c1f6ee0 into main Nov 15, 2023
8 checks passed
@trueadm trueadm deleted the select-fixes branch November 15, 2023 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte 5: select bindings broken when options rendered via #each loop
2 participants