Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format flag issue #59

Merged
merged 3 commits into from
Dec 7, 2019
Merged

Format flag issue #59

merged 3 commits into from
Dec 7, 2019

Conversation

Cyb3r-Jak3
Copy link
Contributor

@Cyb3r-Jak3 Cyb3r-Jak3 commented Oct 24, 2019

- Fixed issue with ```--format``` flag return error when non occured
- Updated Changelog
- Added Gitlab CI intergration
Copy link
Owner

@svenkreiss svenkreiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR!

Minor comments/questions to you.

html5validator/validator.py Outdated Show resolved Hide resolved
html5validator/validator.py Outdated Show resolved Hide resolved
 - Added standard options as DEFAULT_IGNORE messages.
   - Added new tests for checking valid and invalid formatting options
 - Added python 3.7 testing
 - Updated username links
Copy link
Contributor Author

@Cyb3r-Jak3 Cyb3r-Jak3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newest commit has all formats treated the same.

html5validator/validator.py Outdated Show resolved Hide resolved
html5validator/validator.py Outdated Show resolved Hide resolved
html5validator/validator.py Show resolved Hide resolved
html5validator/tests/test_simple.py Show resolved Hide resolved
html5validator/validator.py Outdated Show resolved Hide resolved
html5validator/validator.py Outdated Show resolved Hide resolved
Copy link
Owner

@svenkreiss svenkreiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@svenkreiss svenkreiss merged commit d1d2a27 into svenkreiss:master Dec 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Format flag causes exit 1
2 participants