Disable sax-js strict mode

[mhoffmeyerDC]

This is disabled by default in sax-js, and by their own admission makes sax-js a jerk. Having it enabled also causes bugs like #225 and #272 - breaking svgo entirely for SVG exported from Illustrator with certain settings. Seems more prudent to let some things 'slip by' with strict mode disabled rather than fail entirely.

[aidansteele]

Why was this closed?

[mhoffmeyerDC]

Disabling strict mode broke many of the tests, I think it caused some rounding errors in the SVG.

[aidansteele]

Thanks for such a quick response. Is there a solution on the horizon for the issues linked in the PR?

[mhoffmeyerDC]

The original issue I was having was svgo failing over an SVG with the Adobe Illustrator "preserve editing capabilities" mode enabled . It had some weird namespace convention or character that made sax-js, in strict mode, fail. I guess another solution would be to use a regex to check for that string that sax doesn't like and replace it or delete it.

[aidansteele]

I would suggest that such a regex-stripping solution could be implemented as a plugin, but plugins appear to be executed after sax-js rejects the file.

Given the "hackiness" of a such a regex solution, it still seems like it should be a plugin rather than core functionality - maybe the plugin architecture could be enhanced to support plugins running earlier in the pipeline? I'd be happy to write a plugin to fix this issue, but changing the plugin architecture might be better suited to someone more familiar with the codebase.

[eitanp461]

+1
I am trying to optimize SVGs created wihj Adobe illustrator and the entity references cause sax to fail, i.e. <path style="&st0;" .../>.
Is there any workaround?

[GreLI]

The workaround is to save images in Illustrator with disabled options like “Preserve editing capabilities” (they don't make sense anyway if you are passing that images to svgo). Or it's possible to replace entities with their value manually, but it's suits better if you have only one or few images.