CI: add something to run php tests #1356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svix-onelson
force-pushed
the
onelson/php-ci
branch
30 times, most recently
from
badddd4
to
c688160
Compare
svix-onelson
force-pushed
the
onelson/php-ci
branch
12 times, most recently
from
3f0a12d
to
b1ac65d
Compare
We've got a unit test that checks to see if an exception is thrown when the given timestamp is a float. The test case (which is totally fair) uses an input ending in `.0` which casts cleanly enough to an int with the existing "is_positive_integer" check such that the exception isn't thrown. Adding a call to `is_float()` to this check gets us back to the test passing. N.b. the `+ 0` there is to cast the `$timestamp` variable to an actual numeric type instead of a string for the purpose of the call.
We've got some test that check that verify() doesn't throw an exception, but that function doesn't return anything so we can't assert anything about the outcome. To hush the warnings in the test suite we have to explicitly tell it "we don't expect to make any assertions."
Motivated by superlinter complaining about how long a line was.
svix-onelson
force-pushed
the
onelson/php-ci
branch
from
b1ac65d
to
c6d6485
Compare
svix-james
approved these changes
Jul 5, 2024
svix-jplatte
reviewed
Jul 8, 2024
svix-lucho
added a commit
that referenced
this pull request
Jul 11, 2024
## What's Changed * Enable redis `tcp_nodelay` by @jaymell in #1316 * server: Simplify short-circuiting logic for Option::None by @svix-jplatte in #1318 * Improve database error classification by @svix-jplatte in #1317 * server: Remove unwraps in redis queue module by @svix-jplatte in #1319 * Improve error message by @jaymell in #1320 * Update OpenAPI spec and regenerate libs by @svix-lucho in #1321 * Add NullableBool function by @dacohen in #1322 * bridge: Upgrade omniqueue and related dependencies by @svix-jplatte in #1326 * Make config type, variant names less confusing by @svix-jplatte in #1327 * Redis updates by @jaymell in #1328 * More redis updates by @jaymell in #1329 * bridge: More config cleanup by @svix-jplatte in #1330 * Python: update deps and switch to ruff. by @tasn in #1332 * bridge: Update Cargo.lock by @svix-jplatte in #1334 * Bump locked dependencies again by @svix-jplatte in #1336 * server: Update Cargo.lock by @svix-jplatte in #1337 * build(deps): bump braces from 3.0.2 to 3.0.3 in /javascript by @dependabot in #1335 * bridge: Add Kafka as an input by @svix-jplatte in #1333 * rust: Add Svix::background_task by @svix-jplatte in #1341 * bridge: Reduce deno dependencies by @svix-jplatte in #1343 * rust: Add `Svix::with_token` to allow changing api token by @svix-aaron1011 in #1339 * build(deps): bump ws from 7.4.6 to 7.5.10 in /javascript by @dependabot in #1338 * bridge: Upgrade wiremock dev-dependency by @svix-jplatte in #1344 * bridge: Error refactoring by @svix-jplatte in #1342 * bridge: Add kafka receiver output by @svix-jplatte in #1345 * bridge: Cargo manifest cleanup by @svix-jplatte in #1346 * bridge: Remove build step from CI workflow by @svix-jplatte in #1347 * Fix `Recover Failed Webhooks` response by @jaymell in #1349 * Libs(Go): adjust Go linter by @svix-onelson in #1351 * Libs(Go): pluralize GO_MODULES in superlinter by @svix-onelson in #1353 * build(deps): bump golang.org/x/net from 0.17.0 to 0.23.0 by @dependabot in #1294 * `Recover Failed Webhooks` use configurable `until` by @jaymell in #1352 * Update comments in KafkaConsumer by @svix-jplatte in #1354 * Replace ctype_digit for PHP 8.1 deprecation of non-string arguments by @jterry in #1355 * CI: add something to run php tests by @svix-onelson in #1356 * js: Apply workaround for incomplete fetch support in Cloudflare Worker by @svix-jplatte in #1359 * Bump certifi from 2023.07.22 to 2024.7.4 in /python by @svix-jplatte in #1358 * ci: Update GitHub actions revs for php-ci by @svix-jplatte in #1360 * build(deps): bump zerovec from 0.10.2 to 0.10.4 in /server by @dependabot in #1361 * Server: bump zerovec-derive by @svix-onelson in #1362 * bridge: Add kafka to example configs, config tests by @svix-jplatte in #1357 * Libs: bump spec by @svix-onelson in #1366 ## New Contributors * @dacohen made their first contribution in #1322 * @jterry made their first contribution in #1355 **Full Changelog**: v1.24.0...v1.25.0
svix-onelson
added a commit
to svix-onelson/standard-webhooks
that referenced
this pull request
Jul 12, 2024
A similar change was recently made to the `svix-webhooks` PHP lib, thanks to a user contribution. Motivated by a deprecation warning for PHP 8.1, where there's a behavior change for non-string arguments to `ctype_digit`. Refs: - <svix/svix-webhooks#1355> - <svix/svix-webhooks#1356>
zekth
pushed a commit
to standard-webhooks/standard-webhooks
that referenced
this pull request
Jul 13, 2024
) A similar change was recently made to the `svix-webhooks` PHP lib, thanks to a user contribution. Motivated by a deprecation warning for PHP 8.1, where there's a behavior change for non-string arguments to `ctype_digit`. Refs: - <svix/svix-webhooks#1355> - <svix/svix-webhooks#1356>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We recently had a contribution to the PHP lib and verifying the change was sound turned out to be a bit of a wild goose chase.
Solution
We already had some tests in place so it felt natural to get the suite running in CI.
After getting that going, there were a few warnings and failures that needed fixing up.