svn.cpp: Do not call svn_fs_copied_from on delete #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deleted paths will not be in the repository in the revision where they
were deleted. Calling svn_fs_copied_from() on such a path will return an
error and abort operations, which is not what we want here.
Fix this by not calling svn_fs_copied_form if the change is a deletion
(i.e. change->change_kind == svn_fs_path_change_delete).
Failure to do so leads to error messages when exporting a repository:
Exporting revision 8 svn: E160013: File not found: revision 8, path '/trunk/base/Tcl/pkgIndex.tcl'
Signed-off-by: Clemens Lang <neverpanic@gmail.com>
|
For what its worth, we've hit this same bug on FreeBSD.org for the svn -> git exporter. |
tnyblom
added a commit
that referenced
this pull request
Dec 1, 2015
svn.cpp: Do not call svn_fs_copied_from on delete
glensc
added a commit
to pld-linux/svn-all-fast-export
that referenced
this pull request
Mar 12, 2016
fixes crashes of delete events svn-all-fast-export/svn2git#4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When converting the MacPorts Subversion repository to Git, the conversion fails at revision 8:
I'm not sure whether the offending call to
svn_fs_copied_fromworked in earlier versions of Subversion. For the record, my copy was built against Subversion 1.9.2. My solution for the problem is not callingsvn_fs_copied_fromfor deleted files (because their history must obviously be where they are deleted anyway, you cannot (or can you, but why would you) copy a file and delete it in the same commit).