Making the identityMap a String,String Dictionary #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As mentioned in the according issue, I was not able to reproduce your problem. |
atabaytebrizl
approved these changes
Jul 12, 2020
|
@atabaytebrizl do you maybe have a way to reproduce the issue or even better a failing test case? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QByteArray seemed odd to me for the dictionary, and therefore when it was looking for a value by key from it, it didn't match against a string and would return empty, then add @localhost at the end for the git author. I made the changes below and it seemed to fix the problem i was running into