Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change plugin install strategy to global install #152

Merged
merged 17 commits into from
Nov 18, 2019
Merged

Conversation

xuchaoying
Copy link
Member

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

feature

  • What is the related issue? (Use #issue_id to relate an open issue)

#147 #150

  • Does this PR introduce a breaking change?

no

  • Other information:

@codecov
Copy link

codecov bot commented Nov 14, 2019

Codecov Report

Merging #152 into master will increase coverage by 0.09%.
The diff coverage is 97.32%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #152      +/-   ##
==========================================
+ Coverage   92.37%   92.47%   +0.09%     
==========================================
  Files          45       48       +3     
  Lines        1614     1687      +73     
==========================================
+ Hits         1491     1560      +69     
- Misses        123      127       +4
Impacted Files Coverage Δ
packages/svrx/lib/util/helper.js 100% <ø> (ø) ⬆️
...ges/svrx-util/lib/package-manager/tasks/install.js 85.71% <100%> (ø)
packages/svrx/lib/router/route.js 100% <100%> (ø) ⬆️
...ckages/svrx-util/lib/package-manager/tasks/view.js 100% <100%> (ø)
packages/svrx/lib/plugin/system.js 90.82% <100%> (-0.25%) ⬇️
packages/svrx/lib/plugin/loader.js 100% <100%> (+2.43%) ⬆️
packages/svrx-util/lib/npm/index.js 96.66% <100%> (+0.11%) ⬆️
packages/svrx-util/lib/name-formatter.js 100% <100%> (ø)
packages/svrx-util/lib/package-manager/index.js 100% <100%> (ø)
...util/lib/package-manager/plugin-package-manager.js 100% <100%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78c0520...d2370f3. Read the comment docs.

@xuchaoying xuchaoying requested a review from a team November 14, 2019 07:44
@xuchaoying xuchaoying added the PR: new feature :rocket: New Feature label Nov 14, 2019
@xuchaoying xuchaoying self-assigned this Nov 14, 2019
@xuchaoying xuchaoying added this to the v1.1.0 milestone Nov 14, 2019
@xuchaoying xuchaoying merged commit 293005e into master Nov 18, 2019
@xuchaoying xuchaoying deleted the cy-plugin-install branch November 18, 2019 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: new feature :rocket: New Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants