Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix window.__svrx__ undefined when using require.js #167

Merged
merged 2 commits into from
Dec 10, 2019
Merged

Conversation

xuchaoying
Copy link
Member

@xuchaoying xuchaoying commented Dec 6, 2019

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests is needed?
    • Tests for the changes have been added
  • Docs is needed?
    • Docs have been added / updated

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Enhencement
  • Refactor
  • Documents
  • Others
  1. Change webpack config libraryTarget of the injected svrx client script from umd to window, 'cause we only loaded through a <script> tag

What is the related issue?

#166

Does this PR introduce a breaking change?

  • breaking change?

Other information:

@xuchaoying xuchaoying added the PR: bug fix :bug: Bug Fix label Dec 6, 2019
change libraryTarget of injected client script to 'window'
@codecov
Copy link

codecov bot commented Dec 9, 2019

Codecov Report

Merging #167 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #167   +/-   ##
======================================
  Coverage    95.7%   95.7%           
======================================
  Files          49      49           
  Lines        1675    1675           
======================================
  Hits         1603    1603           
  Misses         72      72

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c68d24...baf1620. Read the comment docs.

@xuchaoying xuchaoying changed the title Fix client script error when using require.js Fix window.__svrx undefined when using require.js Dec 9, 2019
@xuchaoying xuchaoying marked this pull request as ready for review December 9, 2019 07:17
@xuchaoying xuchaoying requested a review from a team December 9, 2019 07:18
@xuchaoying xuchaoying changed the title Fix window.__svrx undefined when using require.js Fix window.__svrx__ undefined when using require.js Dec 9, 2019
@xuchaoying xuchaoying merged commit 55d6aea into master Dec 10, 2019
@xuchaoying xuchaoying deleted the cy-requirejs branch December 10, 2019 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: bug fix :bug: Bug Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants